Messages in this thread | | | Date | Mon, 15 Dec 2008 10:15:25 +0000 | From | Ben Dooks <> | Subject | Re: GPIO: Fix probe() error return in gpio driver probes |
| |
On Sun, Dec 14, 2008 at 04:11:17PM -0800, David Brownell wrote: > On Sunday 14 December 2008, Ben Dooks wrote: > > Has anyone reveiwed this patch? Are there any comments, or can this > > be commited at somepoint (even if it is during the next merge window)? > > I was thinking that -EINVAL is almost the least informative > diagnostic code possible, since so many places return it > that it's usually hard to find out *which* invalid parameter > triggered ... > > Is there a less-overloaded code you could return?
The only other ones that I think would be close are:
ENOTSUP Operation not supported (POSIX.1) EPROTO Protocol error (POSIX.1) ENOENT No such file or directory EFAULT Bad address
Feedback welcone.
> I have no issue with the patch other than that. > > - Dave > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
-- Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
| |