Messages in this thread Patch in this message |  | | | From | Rusty Russell <> | | Subject | Re: [PATCH] KVM: use modern cpumask primitives, no cpumask_t on stack | | Date | Mon, 15 Dec 2008 19:04:35 +1030 | |
On Friday 12 December 2008 03:21:24 Hollis Blanchard wrote:
> This patch breaks uniprocessor builds, because smp_call_function_many()
> is only defined for CONFIG_SMP.
Good catch. I missed it because it's fixed as a side-effect of a
later patch in my series (before I convert users).
Linus, can you please apply this fix?
Thanks,
Rusty.
Subject: Define smp_call_function_many for UP
Otherwise those using it in transition patches (eg. kvm) can't compile
with CONFIG_SMP=n:
arch/x86/kvm/../../../virt/kvm/kvm_main.c: In function 'make_all_cpus_request':
arch/x86/kvm/../../../virt/kvm/kvm_main.c:380: error: implicit declaration of function 'smp_call_function_many'
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
diff --git a/include/linux/smp.h b/include/linux/smp.h
--- a/include/linux/smp.h
+++ b/include/linux/smp.h
@@ -146,6 +147,8 @@ static inline void smp_send_reschedule(i
})
#define smp_call_function_mask(mask, func, info, wait) \
(up_smp_call_function(func, info))
+#define smp_call_function_many(mask, func, info, wait) \
+ (up_smp_call_function(func, info))
static inline void init_call_single_data(void)
{
}
|  |