lkml.org 
[lkml]   [2008]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 03/22] AMD IOMMU: use dev_name instead of self-build print_devid
    Date
    Impact: use generic dev_name instead of own function

    Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
    ---
    arch/x86/include/asm/amd_iommu_types.h | 12 ------------
    arch/x86/kernel/amd_iommu.c | 3 +--
    2 files changed, 1 insertions(+), 14 deletions(-)

    diff --git a/arch/x86/include/asm/amd_iommu_types.h b/arch/x86/include/asm/amd_iommu_types.h
    index 6adc702..ee8cfa0 100644
    --- a/arch/x86/include/asm/amd_iommu_types.h
    +++ b/arch/x86/include/asm/amd_iommu_types.h
    @@ -389,18 +389,6 @@ extern int amd_iommu_isolate;
    */
    extern bool amd_iommu_unmap_flush;

    -/* takes a PCI device id and prints it out in a readable form */
    -static inline void print_devid(u16 devid, int nl)
    -{
    - int bus = devid >> 8;
    - int dev = devid >> 3 & 0x1f;
    - int fn = devid & 0x07;
    -
    - printk("%02x:%02x.%x", bus, dev, fn);
    - if (nl)
    - printk("\n");
    -}
    -
    /* takes bus and device/function and returns the device id
    * FIXME: should that be in generic PCI code? */
    static inline u16 calc_devid(u8 bus, u8 devfn)
    diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
    index cebbf58..dc7cef3 100644
    --- a/arch/x86/kernel/amd_iommu.c
    +++ b/arch/x86/kernel/amd_iommu.c
    @@ -1073,8 +1073,7 @@ static int get_device_resources(struct device *dev,
    *domain = &dma_dom->domain;
    attach_device(*iommu, *domain, *bdf);
    printk(KERN_INFO "AMD IOMMU: Using protection domain %d for "
    - "device ", (*domain)->id);
    - print_devid(_bdf, 1);
    + "device %s\n", (*domain)->id, dev_name(dev));
    }

    if (domain_for_device(_bdf) == NULL)
    --
    1.5.6.4



    \
     
     \ /
      Last update: 2008-12-15 15:23    [W:0.023 / U:0.284 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site