lkml.org 
[lkml]   [2008]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] net: Remove a noisy printk

On Sunday 2008-12-14 18:09, Jozsef Kadlecsik wrote:
>>
>> >> @@ -147,8 +147,6 @@ static unsigned int ipv4_conntrack_local(unsigned int hooknum,
>> >> /* root is playing with raw sockets. */
>> >> if (skb->len < sizeof(struct iphdr) ||
>> >> ip_hdrlen(skb) < sizeof(struct iphdr)) {
>> >> - if (net_ratelimit())
>> >> - printk("ipt_hook: happy cracking.\n");
>> >> return NF_ACCEPT;
>> >> }
>> >> return nf_conntrack_in(dev_net(out), PF_INET, hooknum, skb);
>>
>> I think this change is ok.
>
>In a >normal< system one usually does not use raw sockets. So if a root
>process do use raw socket, at least netfilter sends a notification and
>there's a chance that someone take notice it by checking the kernel logs.
>[...]
>But should we remove them due to nuisances on >test< systems?
>
>Rather make it a kernel compile option but do not remove.

This warning is in the conntrack calling code. Iff you play with
raw sockets and do something wrong, the generic network code
should barf IMHO, not nf_conntrack, and not [nf_conntrack_ipv4 only].


\
 
 \ /
  Last update: 2008-12-14 19:09    [from the cache]
©2003-2011 Jasper Spaans