Messages in this thread |  | | | Date | Thu, 11 Dec 2008 21:23:56 +0200 | | From | Ville Syrjälä <> | | Subject | Re: [PATCH 1/2] PCI Hotplug: acpiphp wants a 64-bit _SUN |
| |
On Thu, Dec 11, 2008 at 11:16:44AM -0700, Alex Chiang wrote: > From: Justin Chen <justin.chen@hp.com> > > Certain HP machines require the full 64 bits of _SUN as allowed > by the ACPI spec. Without this change, we get name collisions in > the lower 32 bits of the _SUN returned by firmware. > > Signed-off-by: Justin Chen <justin.chen@hp.com> > Signed-off-by: Alex Chiang <achiang@hp.com> > --- > diff --git a/drivers/pci/hotplug/acpiphp.h b/drivers/pci/hotplug/acpiphp.h > index f9e244d..9bcb6cb 100644 > --- a/drivers/pci/hotplug/acpiphp.h > +++ b/drivers/pci/hotplug/acpiphp.h > @@ -113,7 +113,7 @@ struct acpiphp_slot { > > u8 device; /* pci device# */ > > - u32 sun; /* ACPI _SUN (slot unique number) */ > + unsigned long long sun; /* ACPI _SUN (slot unique number) */
Why not make it u64 if that's what ACPI says it should be?
-- Ville Syrjälä syrjala@sci.fi http://www.sci.fi/~syrjala/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |