lkml.org 
[lkml]   [2008]   [Dec]   [10]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateWed, 10 Dec 2008 13:25:55 +0800
FromJianjun Kong <>
SubjectRe: [PATCH] rewrite the return method of static int s3c24xx_spi_setup(struct spi_device *spi) in drivers/spi/spi_s3c24xx.c
On Wed, Dec 10, 2008 at 11:01:51AM +0800, Helight.Xu wrote:
>rewrite the return method of static int 
>s3c24xx_spi_setup(struct spi_device *spi) 
>in drivers/spi/spi_s3c24xx.c 
>
>reason:
>s3c24xx_spi_setupxfer(spi, NULL) return 0 or -EINVAL, 
>so here shoud return the ret,but only 0.

The original code can return the correct value.
It contains 0 and -EINVAL, not only 0. So this change is not essential.


-- 
Jianjun Kong |Happy Hacking
Homepage: http://kongove.cn
Gtalk:KongJianjun@gmail.com

\
 
 \ /
  Last update: 2008-12-10 06:29    [from the cache]
©2003-2008