Messages in this thread |  | | | Date | Thu, 11 Dec 2008 04:01:18 +0000 | | From | Al Viro <> | | Subject | Re: [PATCH] fix calls to request_module() |
| |
On Thu, Dec 11, 2008 at 12:35:21PM +0900, Nguyen Anh Quynh wrote: > Hi, > > The request_module() function should always have the 1st param as a > format argument. So for example, request_module("i2c-powermac") should > be called as request_module("%s", "i2c-powermac"). Otherwise, new gcc > like gcc 4.3.2 on Ubuntu 8.10 would spit out a lot of warnings. This > patch fixes them all in linus-git tree.
... and it doesn't address the underlying problems at all. A string literal without a single % in it is a perfectly sane and valid format. _Why_ are we getting these warning?
|  |