lkml.org 
[lkml]   [2008]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] fix calls to request_module()
    On Thu, Dec 11, 2008 at 12:35:21PM +0900, Nguyen Anh Quynh wrote:
    > Hi,
    >
    > The request_module() function should always have the 1st param as a
    > format argument. So for example, request_module("i2c-powermac") should
    > be called as request_module("%s", "i2c-powermac"). Otherwise, new gcc
    > like gcc 4.3.2 on Ubuntu 8.10 would spit out a lot of warnings. This
    > patch fixes them all in linus-git tree.

    ... and it doesn't address the underlying problems at all. A string literal
    without a single % in it is a perfectly sane and valid format. _Why_ are
    we getting these warning?


    \
     
     \ /
      Last update: 2008-12-11 05:03    [W:0.018 / U:33.008 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site