lkml.org 
[lkml]   [2008]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Do not pass the SLAB flags as GFP in slob kmem_cache_create
[Christoph Lameter - Wed, Dec 10, 2008 at 02:11:23PM -0600]
| On Wed, 10 Dec 2008, Cyrill Gorcunov wrote:
|
| > this would make the following line in slob_alloc
| >
| > ...
| > if (unlikely((gfp & __GFP_ZERO) && b))
| > memset(b, 0, size);
| > ...
| >
| > useless. Not sure if it will be good :)
|
| No. GFP_ZERO is set when kmalloc etc is called. Its not set on
| kmem_cache_create.
|

yep, Matt already pointed, I just missed first time.

- Cyrill -


\
 
 \ /
  Last update: 2008-12-10 21:31    [W:0.793 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site