lkml.org 
[lkml]   [2008]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    Subject[PATCH 4/9] mISDN: fix sparse warnings
    From
    Impact: make an exported symbol non static

    Fix this warning:

    drivers/isdn/hardware/mISDN/hfcmulti.c:176:1: warning: symbol 'plx_lock' shadows an earlier one
    drivers/isdn/hardware/mISDN/hfcmulti.c:175:19: originally declared here

    Signed-off-by: Hannes Eder <hannes@hanneseder.net>
    ---

    Note that patch introduces this new warning:

    drivers/isdn/hardware/mISDN/hfcmulti.c:175:12: warning: symbol 'plx_lock' was not declared. Should it be static?

    Should 'plx_lock' be declared in a header file? Or is it really
    neccessart to export it?


    drivers/isdn/hardware/mISDN/hfcmulti.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/isdn/hardware/mISDN/hfcmulti.c b/drivers/isdn/hardware/mISDN/hfcmulti.c
    index 599d832..b4595f7 100644
    --- a/drivers/isdn/hardware/mISDN/hfcmulti.c
    +++ b/drivers/isdn/hardware/mISDN/hfcmulti.c
    @@ -172,7 +172,7 @@ static int interrupt_registered;

    static struct hfc_multi *syncmaster;
    static int plxsd_master; /* if we have a master card (yet) */
    -static spinlock_t plx_lock; /* may not acquire other lock inside */
    +spinlock_t plx_lock; /* may not acquire other lock inside */
    EXPORT_SYMBOL(plx_lock);

    #define TYP_E1 1
    --
    1.5.6.3


    \
     
     \ /
      Last update: 2008-12-10 17:17    [W:0.031 / U:0.100 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site