lkml.org 
[lkml]   [2008]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Regression from 2.6.26: Hibernation (possibly suspend) broken on Toshiba R500 (bisected)


On Mon, 1 Dec 2008, Linus Torvalds wrote:
>
> or something like that. And then we just need to figure out which setup
> routine sets the wrong alignment flag,.

Oh, btw, one more thing: since it apparently sometimes _does_ resume
from hibernation without all this, I'd also like to see the actual
differences in /proc/ioports and /proc/iomem that happen as a result of
the different alignment.

I also really suspect we should add a whole "alignment" field to "struct
resource", instead of the size-vs-start flags. The fact is, some PCI
devices have alignment that is neither tied to size or anything else: I
think some PCI bus resources are really always 4kB-aligned, for example
(and aligning them by size will give a bigger alignment than actually
required).

Linus


\
 
 \ /
  Last update: 2008-12-02 04:45    [W:1.800 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site