lkml.org 
[lkml]   [2008]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [TOMOYO #13 (mmotm 2008-11-19-02-19) 01/11] Introduce security_path_clear() hook.
    From
    Date
    On Thu, 2008-11-20 at 20:25 +0900, Tetsuo Handa wrote:
    > plain text document attachment (introduce-security_path_clear.patch)
    > To perform DAC performed in vfs_foo() before MAC, we let security_path_foo()
    > save a result into our own hash table and return 0, and let security_inode_foo()
    > return the saved result. Since security_inode_foo() is not always called after
    > security_path_foo(), we need security_path_clear() to clear the hash table.

    This seems very fragile and unmaintainable to me. The fact that you
    even need a security_path_clear() hook suggests that something is wrong
    with the other security_path* hooks. I'd suggest that you explicitly
    pass the result of the security_path* hooks down to the security_inode*
    hooks instead. What do others think?

    --
    Stephen Smalley
    National Security Agency



    \
     
     \ /
      Last update: 2008-12-01 21:07    [W:0.022 / U:0.724 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site