Messages in this thread | | | Date | Mon, 1 Dec 2008 10:37:41 -0800 | From | Andrew Morton <> | Subject | Re: mmotm 2008-11-26-17-00 uploaded (hwmon / dev_attr_name) |
| |
On Mon, 1 Dec 2008 14:56:34 +0100 Rodolfo Giometti <giometti@enneenne.com> wrote:
> We can just remove the DEVICE_ATTR(name, ...) since all the variables > are into pps_attrs[]. > > Please, let me know if you wish a proper patch for this or you can do > it by yourself.
I'll sort it out.
> > drivers/pps/clients/pps-ldisc.c: In function 'pps_tty_dcd_change': > > drivers/pps/clients/pps-ldisc.c:32: warning: cast from pointer to integer of different size > > drivers/pps/clients/pps-ldisc.c: In function 'pps_tty_open': > > drivers/pps/clients/pps-ldisc.c:77: warning: cast to pointer from integer of different size > > drivers/pps/clients/pps-ldisc.c:82: warning: cast from pointer to integer of different size > > drivers/pps/clients/pps-ldisc.c: In function 'pps_tty_close': > > drivers/pps/clients/pps-ldisc.c:91: warning: cast from pointer to integer of different size > > > > > > For the ->disc_data warnings you could perhaps just make all the > > relevant scalar types `long', not `int'. > > But doing like this will breaks 32bit archs... =:-o
I don't think so. sizeof(long) == sizeof(int) on 32-bit.
| |