lkml.org 
[lkml]   [2008]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: PATCH: /proc/acpi/alarm: handle day-of-month wraparound on readback


    On Mon, 1 Dec 2008, Mark Lord wrote:

    > Fix month wrap issue with readback from /proc/acpi/alarm
    > This bug has been around *forever*.
    >
    > $ echo '2008-12-01 10:36:20' > /proc/acpi/alarm
    > $ cat /proc/acpi/alarm
    > 2008-11-01 10:36:20
    >
    > Note how the readback above shows the month incorrectly.
    > But with this patch applied, it shows the correct month (12).
    >
    > Patch applies/works on kernels 2.6.25.* through 2.6.27.*,
    > and probably on earlier kernels as well.

    We've had some BCD_TO_BIN() changes here in 2.6.28 already,
    does 2.6.28-rc still have this bug?

    I'd check myself, but I don't have a /proc/acpi/alarm due to this:

    #if defined(CONFIG_RTC_DRV_CMOS) || defined(CONFIG_RTC_DRV_CMOS_MODULE) ||
    !defined(CONFIG_X86)
    /* use /sys/class/rtc/rtcX/wakealarm instead; it's not ACPI-specific */
    #else
    #define HAVE_ACPI_LEGACY_ALARM
    #endif


    thanks,
    -Len



    \
     
     \ /
      Last update: 2008-12-01 19:21    [W:0.032 / U:1.408 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site