lkml.org 
[lkml]   [2008]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] drivers/mtd/nand/pasemi_nand.c: Add missing pci_dev_put
    On Mon, 1 Dec 2008, Olof Johansson wrote:

    > On Mon, Dec 01, 2008 at 06:39:01PM +0100, Julia Lawall wrote:
    > > On Mon, 1 Dec 2008, Olof Johansson wrote:
    > >
    > > > On Thu, Nov 27, 2008 at 01:19:49PM +0100, Julia Lawall wrote:
    > > > > From: Julia Lawall <julia@diku.dk>
    > > > >
    > > > > pci_get_device increments a reference count that should be decremented
    > > > > using pci_dev_put. I have thus added an extra label in the error handling
    > > > > code to do this. I don't know, however, whether there should be a
    > > > > pci_dev_put before the return 0 as well.
    > > > >
    > > > [...]
    > > >
    > > > > Signed-off-by: Julia Lawall <julia@diku.dk>
    > > >
    > > > Acked-by: Olof Johansson <olof@lixom.net>
    > >
    > > Do you know the answer about the return 0?
    >
    > Teaches me to read the patch description twice.
    >
    > Either there or in pasemi_nand_remove(), doesn't matter much to me. Doing
    > it before the return 0 is the smaller change.

    OK, I will send an adjusted patch shortly.

    Thanks,
    julia


    \
     
     \ /
      Last update: 2008-12-01 19:05    [W:0.040 / U:157.288 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site