Messages in this thread | | | Date | Mon, 10 Nov 2008 13:41:32 +1100 | From | Paul Mackerras <> | Subject | Re: [patch 00/24] perfmon3: introduction |
| |
Stephane,
I have just looked through this set of patches and it mostly looks fine to me. There is just one thing, and that is that the way you access bitmaps using cast_ulp() won't work on 32-bit big-endian machines such as 32-bit PowerPC. I suggest that instead of using cast_ulp(), you have a set of abstracted bit-vector operations that can be implemented by the arch code - and on x86/ia64, they would be implemented with cast_ulp() + test_bit/__set_bit/etc. as at present.
I hope we can get these patches into 2.6.29.
Regards, Paul.
| |