lkml.org 
[lkml]   [2008]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] add /proc/pid/stack to dump task's stack trace
On Fri, Nov 07, 2008 at 08:59:25AM +0100, Ingo Molnar wrote:
>
> * Ingo Molnar <mingo@elte.hu> wrote:
>
> > > > + * buffer size used for proc read. See proc_info_read().
> > > > + * 4K page size but our output routines use some slack for overruns
> > > > + */
> > > > +#define PROC_BLOCK_SIZE (3*1024)
> >
> > That sounds like a proper limit - the hard limit for this particular
> > printout function is 4096-170, so we are well within the
> > PROC_BLOCK_SIZE range.
>
> ok, i've added Ken's patch to tip/core/stacktrace and started testing
> it.
>
> Alexey, i've added your Acked-by because you appeared to like the
> patch - let me know if i should remove it.

Of course, I don't like it!

Switch to seqfiles, add entry in TID table as well.

The idea is good, though.


\
 
 \ /
  Last update: 2008-11-07 09:21    [W:0.061 / U:2.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site