Messages in this thread | | | Date | Fri, 7 Nov 2008 11:20:03 +0300 | From | Alexey Dobriyan <> | Subject | Re: [patch] add /proc/pid/stack to dump task's stack trace |
| |
On Fri, Nov 07, 2008 at 08:59:25AM +0100, Ingo Molnar wrote: > > * Ingo Molnar <mingo@elte.hu> wrote: > > > > > + * buffer size used for proc read. See proc_info_read(). > > > > + * 4K page size but our output routines use some slack for overruns > > > > + */ > > > > +#define PROC_BLOCK_SIZE (3*1024) > > > > That sounds like a proper limit - the hard limit for this particular > > printout function is 4096-170, so we are well within the > > PROC_BLOCK_SIZE range. > > ok, i've added Ken's patch to tip/core/stacktrace and started testing > it. > > Alexey, i've added your Acked-by because you appeared to like the > patch - let me know if i should remove it.
Of course, I don't like it!
Switch to seqfiles, add entry in TID table as well.
The idea is good, though.
| |