Messages in this thread | | | Date | Fri, 7 Nov 2008 02:09:04 -0500 | From | "Mike Frysinger" <> | Subject | Re: [PATCH] ALSA: have snd_BUG_ON() always refer to arguments |
| |
On Fri, Nov 7, 2008 at 01:22, Takashi Iwai wrote: > At Thu, 6 Nov 2008 21:05:21 -0500, > Mike Frysinger wrote: >> The snd_BUG_ON() macro should always expand its argument even if we're >> forcing it to false. This kills off unused warnings that did not exist >> before the snd_assert() -> snd_BUG_ON() conversion. > > Andrew already change this differently. Check with the latest version.
what are you defining as "latest version" ? i'm looking in torvalds linux-2.6.git.
> And which warning did you get actually?
a few codecs define local vars which only get used in snd_BUG_ON() ... so if snd_BUG_ON() doesnt utilize cond, gcc whines that the var is unused. -mike
| |