Messages in this thread | | | Date | Thu, 6 Nov 2008 08:20:56 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] ftrace: add an fsync tracer |
| |
* Arjan van de Ven <arjan@infradead.org> wrote:
> > > + buffer = kmalloc(4096, GFP_KERNEL);
> > > + err = d_path(&file->f_path, buffer, 4096);
hm, magic constants.
> > > + if (IS_ERR(err)) > > > + goto out; > > > + > > > + ftrace_printk("Process %s is calling fsync on %s\n", > > > + current->comm, err); > > > > err? not buffer? > > correct, not buffer > > it won't work if you use buffer.
please use some other name than 'err' - since "error" is just a property of the path string pointer you get back from do_path().
Ingo
| |