[lkml]   [2008]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] x86: call machine_shutdown and stop all CPUs in native_machine_halt

    * Ivan Vecera <> wrote:

    > Ingo Molnar wrote:
    > > the code in arch/x86/kernel/smp.c::stop_this_cpu() is very similar to
    > > this and could be shared. You could move the stop_this_cpu() function to
    > > arch/x86/kernel/process.c (out of smp.c), so that it can be used by
    > > reboot.c.
    > >
    > Yes, this make sense. Here is the patch.

    looks good. One small detail:

    > +#ifdef CONFIG_X86_LOCAL_APIC
    > + disable_local_APIC();
    > +#endif

    could you please avoid this #ifdef by putting an inline void function
    for disable_local_APIC() into arch/x86/include/asm/apic.h for the
    !CONFIG_X86_LOCAL_APIC case?


     \ /
      Last update: 2008-11-06 21:47    [W:0.026 / U:9.440 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site