lkml.org 
[lkml]   [2008]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH]: ext4: fix big endian
Date
Am Donnerstag, 6. November 2008 schrieb Peter Staubach:
> > /* We allocate both existing and potentially added groups */
> > flex_group_count = ((sbi->s_groups_count + groups_per_flex - 1) +
> > - ((sbi->s_es->s_reserved_gdt_blocks +1 ) <<
> > + (le16_to_cpu(sbi->s_es->s_reserved_gdt_blocks + 1) <<
> >
>
> I suspect that you want to do the le16_to_cpu() and _then_
> add the 1. Otherwise, adding 1 to a different byte order
> value won't do quite what is expected or hoped for...

errm. Right.
Something like this maybe?

[PATCH]: ext4: fix big endian access for flex groups

On big endianess plattforms newly created ext4 file systems cannot be mounted
and show messages like:
[6923911.715968] EXT4-fs: not enough memory for 522250 flex groups
[6923911.715973] EXT4-fs: unable to initialize flex_bg meta info!

We have to access s_reserved_gdb_blocks with le16_to_cpu.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
fs/ext4/super.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Index: kvm/fs/ext4/super.c
===================================================================
--- kvm.orig/fs/ext4/super.c
+++ kvm/fs/ext4/super.c
@@ -1455,8 +1455,8 @@ static int ext4_fill_flex_info(struct su

/* We allocate both existing and potentially added groups */
flex_group_count = ((sbi->s_groups_count + groups_per_flex - 1) +
- ((sbi->s_es->s_reserved_gdt_blocks +1 ) <<
- EXT4_DESC_PER_BLOCK_BITS(sb))) /
+ ((le16_to_cpu(sbi->s_es->s_reserved_gdt_blocks) +
+ 1) << EXT4_DESC_PER_BLOCK_BITS(sb))) /
groups_per_flex;
sbi->s_flex_groups = kzalloc(flex_group_count *
sizeof(struct flex_groups), GFP_KERNEL);

\
 
 \ /
  Last update: 2008-11-06 17:19    [W:0.053 / U:0.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site