Messages in this thread | | | Date | Wed, 05 Nov 2008 15:00:20 +0200 | From | Boaz Harrosh <> | Subject | Re: [PATCH 03/18] libosd: OSDv1 Headers |
| |
Jörn Engel wrote: > On Tue, 4 November 2008 11:10:37 -0800, Andrew Morton wrote: >> etc, etc, etc. Please review all that. > > One easy way to review 98% is to include the header in an otherwise > empty foo.c and compile that. The remaining 2% are hidden behind > different config options and architectures. Although your header may be > fine on that front. > > Jörn >
I have done just that. It's an old habit of mine. The very first #include in osd_initiator.c is osd_initiator.h precisely for that. So it's not just a one time test it's always tested.
Thanks Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |