Messages in this thread | | | Date | Tue, 04 Nov 2008 18:06:14 +0800 | From | Li Zefan <> | Subject | Re: [PATCH] sched: add sanity check in partition_sched_domains() |
| |
> a small detail, i changed this: > >> + BUG_ON(dattr_new); > > to WARN_ON_ONCE(). > > If there's a rare setup-time memory leak we dont want to crash the box > via a BUG_ON(), as that only results in unhappy users. We want a > WARN_ON_ONCE() so that we get nice bugreports and kerneloops.org > coverage as well instead. > > We use BUG_ON() in new code only in the rarest of circumstances: if we > absolutely want to bring down the box right there - because there's a > serious risk of data corruption, security breach, etc. >
I see the point, thx for the explanation. :)
| |