lkml.org 
[lkml]   [2008]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] Block: use round_jiffies_up()
    Hello,

    Alan Stern wrote:
    > @@ -78,13 +78,14 @@ void blk_delete_timer(struct request *re
    > /*
    > * Nothing to detach
    > */
    > - if (!q->rq_timed_out_fn || !req->deadline)
    > + if (!req->deadline)
    > return;
    >
    > list_del_init(&req->timeout_list);
    >
    > if (list_empty(&q->timeout_list))
    > del_timer(&q->timeout);
    > + req->deadline = 0;
    > }

    Actually, this can just be

    blk_delete_timer()
    {
    list_del_init(&req->timeout_list);
    if (list_empty(&q->timeout_list))
    del_timer(&q->timeout);
    }

    and none of req->deadline trick is necessary.

    Thanks.

    --
    tejun


    \
     
     \ /
      Last update: 2008-11-05 04:37    [W:0.023 / U:30.944 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site