Messages in this thread | | | Date | Wed, 5 Nov 2008 08:54:40 +0530 | From | Bharata B Rao <> | Subject | Re: [PATCH] Add hierarchical accounting to cpu accounting controller |
| |
On Tue, Nov 04, 2008 at 09:20:40AM -0800, Randy Dunlap wrote: > On Tue, 4 Nov 2008 18:19:37 +0530 Bharata B Rao wrote: > > > Add hierarchical accounting to cpu accounting controller and cpuacct > > documentation. > > > > Currently, while charging the task's cputime to its accounting group, > > the accounting group hierarchy isn't updated. This patch charges the cputime > > of a task to its accounting group and all its parent accounting groups. > > > > Reported-by: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com> > > Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com> > > CC: Peter Zijlstra <a.p.zijlstra@chello.nl> > > CC: Ingo Molnar <mingo@elte.hu> > > CC: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com> > > Reviewed-by: Paul Menage <menage@google.com> > > --- > > Documentation/controllers/cpuacct.txt | 32 ++++++++++++++++++++++++++++++++ > > kernel/sched.c | 10 ++++++++-- > > 2 files changed, 40 insertions(+), 2 deletions(-) > > > > --- /dev/null > > +++ b/Documentation/controllers/cpuacct.txt > > @@ -0,0 +1,32 @@ > > +CPU Accounting Controller > > +------------------------- > > + > > +The CPU accounting controller is used to group tasks using cgroups and > > +account the CPU usage of these group of tasks. > > + > > +The CPU accounting controller supports multi-hierarchy groups. An accounting > > +group accumulates the CPU usage of all of it's child groups and > > its {it's means "it is"} > > > +the tasks directly present in it's group. > > its
You are right, I was under the wrong impression that possessive case of "it" is still "it's".
I will resend the patch with other corrections you mentioned only if Paul/Ingo want this patch to go in.
Thanks for your comments.
Regards, Bharata.
| |