Messages in this thread Patch in this message |  | | | Date | Tue, 4 Nov 2008 15:31:24 -0800 | | From | Greg KH <> | | Subject | [patch 13/57] libata: initialize port_task when !CONFIG_ATA_SFF |
| |
2.6.27-stable review patch. If anyone has any objections, please let us know.
------------------ From: Tejun Heo <tj@kernel.org> commit f667fdbbbea8bcce6cf9f7acb51b7cb4c264cc61 upstream
ap->port_task was not initialized if !CONFIG_ATA_SFF later triggering lockdep warning. Make sure it's initialized.
Reported by Larry Finger.
Signed-off-by: Tejun Heo <tj@kernel.org> Cc: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Jeff Garzik <jgarzik@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- drivers/ata/libata-core.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -5259,6 +5259,8 @@ struct ata_port *ata_port_alloc(struct a #ifdef CONFIG_ATA_SFF INIT_DELAYED_WORK(&ap->port_task, ata_pio_task); +#else + INIT_DELAYED_WORK(&ap->port_task, NULL); #endif INIT_DELAYED_WORK(&ap->hotplug_task, ata_scsi_hotplug); INIT_WORK(&ap->scsi_rescan_task, ata_scsi_dev_rescan); --
|  |