Messages in this thread | | | Date | Tue, 4 Nov 2008 21:29:09 +0100 | From | Jörn Engel <> | Subject | Re: [PATCH 03/18] libosd: OSDv1 Headers |
| |
On Tue, 4 November 2008 20:42:40 +0100, Jörn Engel wrote: > On Tue, 4 November 2008 11:10:37 -0800, Andrew Morton wrote: > > > > etc, etc, etc. Please review all that. > > One easy way to review 98% is to include the header in an otherwise > empty foo.c and compile that. The remaining 2% are hidden behind > different config options and architectures. Although your header may be > fine on that front.
Btw, running such a script on include/linux detects a lot of trouble even with i386 allnoconfig. Most of which looks it could be 'fixed' by a drunken monkey inserting #includes. But some of those #includes may be fs.h and pull the kitchensink, adding tons of dependencies and some compile time.
Unsure.
Jörn
-- Rules of Optimization: Rule 1: Don't do it. Rule 2 (for experts only): Don't do it yet. -- M.A. Jackson -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |