[lkml]   [2008]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    SubjectRe: [PATCH 07/16] x86: Make nmi_shootdown_cpus() available on !SMP and !X86_LOCAL_APIC

    On Tue, Nov 04, 2008 at 12:52:35PM -0200, Eduardo Habkost wrote:
    > The X86_LOCAL_APIC #ifdef was for kdump. For !SMP, the function simply
    > does nothing.

    The bit below is also needed. It can be added to the series right before
    patch 07/16.

    After getting some review, I will resubmit the series with it, and with
    a few style fixes suggested by checkpatch.

    From: Eduardo Habkost <>
    Subject: [PATCH 06.1/16] x86: Disable IRQs before doing anything on nmi_shootdown_cpus()

    We need to know on which CPU we are running on, and we don't want to be
    preempted while doing this.

    Signed-off-by: Eduardo Habkost <>
    arch/x86/kernel/reboot.c | 1 +
    1 files changed, 1 insertions(+), 0 deletions(-)

    diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
    index 23a9d78..407106e 100644
    --- a/arch/x86/kernel/reboot.c
    +++ b/arch/x86/kernel/reboot.c
    @@ -577,6 +577,7 @@ static struct notifier_block crash_nmi_nb = {
    void nmi_shootdown_cpus(nmi_shootdown_cb callback)
    unsigned long msecs;
    + local_irq_disable();

    /* Make a note of crashing cpu. Will be used in NMI callback.*/
    crashing_cpu = safe_smp_processor_id();


     \ /
      Last update: 2008-11-04 19:19    [W:0.022 / U:0.532 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site