Messages in this thread |  | | | Date | Tue, 4 Nov 2008 15:25:51 +0900 | | From | KAMEZAWA Hiroyuki <> | | Subject | Re: [RFC][PATCH 1/5] memcg : force_empty to do move account | |
On Mon, 3 Nov 2008 22:23:11 -0800
Paul Menage <menage@google.com> wrote:
> On Mon, Nov 3, 2008 at 10:17 PM, KAMEZAWA Hiroyuki
> <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> >> >
> >> > mem = memcg;
> >> > - ret = mem_cgroup_try_charge(mm, gfp_mask, &mem);
> >> > + ret = __mem_cgroup_try_charge(mm, gfp_mask, &mem, true);
> >>
> >> Isn't this the same as the definition of mem_cgroup_try_charge()? So
> >> you could leave it as-is?
> >>
> > try_charge is called by other places....swapin.
> >
>
> No, I mean here you can call mem_cgroup_try_charge(...) rather than
> __mem_cgroup_try_charge(..., true).
>
you're right. will remove this change.
Thanks,
-Kame
|  |