lkml.org 
[lkml]   [2008]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] sata_via: restore vt*_prepare_host error handling
    Marcin Slusarz wrote:
    > commit b9d5b89b487517cbd4cb4702da829e07ef9e4432 (sata_via: fix support
    > for 5287) accidently (?) removed vt*_prepare_host error handling - restore it
    >
    > catched by gcc:
    > drivers/ata/sata_via.c: In function 'svia_init_one':
    > drivers/ata/sata_via.c:567: warning: 'host' may be used uninitialized in this function
    >
    > Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
    > Cc: Tejun Heo <tj@kernel.org>
    > Cc: Joseph Chan <JosephChan@via.com.tw>
    > Cc: Jeff Garzik <jgarzik@redhat.com>
    > ---
    > drivers/ata/sata_via.c | 4 +++-
    > 1 files changed, 3 insertions(+), 1 deletions(-)
    >
    > diff --git a/drivers/ata/sata_via.c b/drivers/ata/sata_via.c
    > index 62367fe..c18935f 100644
    > --- a/drivers/ata/sata_via.c
    > +++ b/drivers/ata/sata_via.c
    > @@ -602,8 +602,10 @@ static int svia_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
    > rc = vt8251_prepare_host(pdev, &host);
    > break;
    > default:
    > - return -EINVAL;
    > + rc = -EINVAL;
    > }
    > + if (rc)
    > + return rc;

    applied




    \
     
     \ /
      Last update: 2008-11-04 07:17    [W:0.021 / U:0.232 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site