Messages in this thread | | | Date | Mon, 3 Nov 2008 15:01:04 -0800 | From | Arthur Jones <> | Subject | Re: [PATCH] ext3: wait on all pending commits in ext3_sync_fs |
| |
Hi Ted, ...
On Mon, Nov 03, 2008 at 02:55:44PM -0800, Theodore Tso wrote: > @@ -2922,15 +2919,15 @@ static void ext4_write_super(struct super_block *sb) > > static int ext4_sync_fs(struct super_block *sb, int wait) > { > - tid_t target; > + int ret; > > trace_mark(ext4_sync_fs, "dev %s wait %d", sb->s_id, wait); > sb->s_dirt = 0; > - if (jbd2_journal_start_commit(EXT4_SB(sb)->s_journal, &target)) { > - if (wait) > - jbd2_log_wait_commit(EXT4_SB(sb)->s_journal, target); > - } > - return 0; > + if (wait) > + ret = ext4_force_commit(sb); > + else > + ret = jbd2_journal_start_commit(EXT4_SB(sb)->s_journal, NULL); > + return ret; > } > > /*
Same problem as the last one, jbd2_journal_start_commit returns true if it started a commit, not an error...
Arthur
| |