lkml.org 
[lkml]   [2008]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] ext3: wait on all pending commits in ext3_sync_fs
    On Mon, Nov 03, 2008 at 01:13:13PM -0800, Andrew Morton wrote:
    > On Mon, 3 Nov 2008 12:58:54 -0800
    > Arthur Jones <ajones@riverbed.com> wrote:
    >
    > > Hi Andrew, ...
    > >
    > > On Mon, Nov 03, 2008 at 12:37:50PM -0800, Andrew Morton wrote:
    > > > [...]
    > > > OK. But still, questions remain.
    > > >
    > > > - should we clear s_dirt if log_wait_commit() didn't work?
    > > >
    > > > - ext3_force_commit() clears s_dirt also
    > > >
    > > > - should ext3_sync_fs() be dropping the ext3_force_commit() return
    > > > value on the floor?

    Should all the callers of ->sync_fs also be dropping the error returns
    on the floor?

    > >
    > > - does ext4 have a similar issue (ext4_sync_fs looks the same)?
    > >
    >
    > I'm sure it does. Someone(tm) should prepare the ext4 patch once we've
    > settled on the ext3 patch.

    I'll take care of it. And I would reflect the error returns up to
    ext3_sync_fs's callers, although at the moment it's not clear it would
    make much of a difference. :-(

    - Ted


    \
     
     \ /
      Last update: 2008-11-03 22:23    [from the cache]
    ©2003-2011 Jasper Spaans. Advertise on this site