lkml.org 
[lkml]   [2008]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V2 00/16] Squashfs: compressed read-only filesystem
    Hi.

    On Wed, Oct 29, 2008 at 01:49:55AM +0000, Phillip Lougher (phillip@lougher.demon.co.uk) wrote:
    > Summary of changes in patch respin:
    >
    > 1. Functions changed to return 0 on success and -ESOMETHING on error
    > 2. Header files moved from include/linux to fs/squashfs
    > 3. Variables changed to use sb and inode
    > 4. Number of squashfs_read_metadata() parameters reduced
    > 5. Xattr placeholder code tweaked
    > 6. TRACE and ERROR macros fixed to use pr_debug and pr_warning
    > 7. Some obsolete macros in squashfs_fs.h removed
    > 8. A number of gotos to return statements replaced with direct returns
    > 9. Sparse with endian checking (make C=2 CHECKFLAGS="-D__CHECK_ENDIAN__")
    > errors fixed
    > 10. get_dir_index_using_name() misaligned access fixed
    > 11. Fix a couple of printk warnings on PPC64
    > 12. Shorten a number of variable names

    Looks very good.

    As a generic comment of the style: imho u64 is more appropriate than
    long long, at least it is less keys to press when typing :)

    --
    Evgeniy Polyakov


    \
     
     \ /
      Last update: 2008-11-03 15:17    [W:0.022 / U:0.876 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site