Messages in this thread | ![/](/images/icornerl.gif) | | Date | Sat, 29 Nov 2008 08:27:16 -0500 | From | roel kluin <> | Subject | Re: powerpc: hv{cs,si}_close() both unsigned hp->count and hvcsd->open_count cannot be negative |
| |
Andreas Schwab wrote: > roel kluin <roel.kluin@gmail.com> writes: > >> - if (--hvcsd->open_count == 0) { >> + if (hvcsd->open_count == 1) { >> + hvcsd->open_count--; > > This is not the same.
I think you're missing that I also decrement if (hvcsd->open_count > 1) If not, please elaborate.
> >> - if (--hp->count == 0) { >> + if (hp->count == 1) { >> + hp->count--; > > Likewise.
Same here.
Roel
| ![\](/images/icornerr.gif) |