Messages in this thread | | | Date | Sat, 29 Nov 2008 17:00:36 +0530 | From | Mahesh Jagannath Salgaonkar <> | Subject | Re: [PATCH] Don't export sched_mc_power_savings in laptops |
| |
Mahesh Salgaonkar wrote: > Fix to prevent sched_mc_power_saving from being exported through sysfs > for multicore single socket (Laptop). > > CPU core map of the boot cpu should be equal to possible number > of cpus for single socket system. > > This fix has been developed at FOSS.in kernel workout. > > Signed-off-by: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com> > > diff --git a/arch/x86/include/asm/topology.h b/arch/x86/include/asm/topology.h > index 4850e4b..4adc830 100644 > --- a/arch/x86/include/asm/topology.h > +++ b/arch/x86/include/asm/topology.h > @@ -239,7 +239,7 @@ struct pci_bus; > void set_pci_bus_resources_arch_default(struct pci_bus *b); > > #ifdef CONFIG_SMP > -#define mc_capable() (boot_cpu_data.x86_max_cores > 1) > +#define mc_capable() (cpus_weight(per_cpu(cpu_core_map,0)) != nr_cpu_ids) > #define smt_capable() (smp_num_siblings > 1) > #endif > >
The sched_mc_power_savings in sysfs does not help on single socket multicore laptops. The above patch has been tested on dual core laptop and dual socket quad core intel processor based server.
Thanks, -Mahesh.
| |