Messages in this thread | | | Date | Fri, 28 Nov 2008 05:14:43 +0000 | From | Al Viro <> | Subject | Re: [PATCH -v3 8/8] dnotify: reimplement dnotify using fsnotify |
| |
On Tue, Nov 25, 2008 at 12:21:33PM -0500, Eric Paris wrote:
> + .mark_clear_inode = clear_mark_dir_notify,
... called under a spinlock
> +static void clear_mark_dir_notify(struct fsnotify_mark_entry *entry, struct inode *inode, unsigned long mask __attribute__ ((unused)), unsigned int flags) > +{ ... > + fsnotify_put_group(dnotify_group);
... which grabs a mutex.
Incidentally, why the hell do you bother with refcounting on groups here? dnotify is not something that's going to be unloaded, for fsck sake...
| |