Messages in this thread Patch in this message | | | Date | Thu, 27 Nov 2008 23:12:37 +0300 | From | Cyrill Gorcunov <> | Subject | [PATCH] net: ppp_asynctty_ioctl - remove dead code |
| |
ap already checked to be not null. remove useless checks.
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> ---
Please review
diff --git a/drivers/net/ppp_async.c b/drivers/net/ppp_async.c index 451bdb5..6567fab 100644 --- a/drivers/net/ppp_async.c +++ b/drivers/net/ppp_async.c @@ -293,9 +293,6 @@ ppp_asynctty_ioctl(struct tty_struct *tty, struct file *file, err = -EFAULT; switch (cmd) { case PPPIOCGCHAN: - err = -ENXIO; - if (!ap) - break; err = -EFAULT; if (put_user(ppp_channel_index(&ap->chan), p)) break; @@ -303,9 +300,6 @@ ppp_asynctty_ioctl(struct tty_struct *tty, struct file *file, break; case PPPIOCGUNIT: - err = -ENXIO; - if (!ap) - break; err = -EFAULT; if (put_user(ppp_unit_number(&ap->chan), p)) break;
| |