lkml.org 
[lkml]   [2008]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -v3 5/8] fsnotify: unified filesystem notification backend
From
Date
On Tue, 2008-11-25 at 12:21 -0500, Eric Paris wrote:
> +
> +void fsnotify_put_group(struct fsnotify_group *group)
> +{
> + mutex_lock(&fsnotify_grp_mutex);
> + if (atomic_dec_and_test(&group->refcnt)) {
> + list_del_rcu(&group->group_list);
> + mutex_unlock(&fsnotify_grp_mutex);
> +
> + synchronize_srcu(&fsnotify_grp_srcu_struct);
> +
> + fsnotify_recalc_global_mask();
> + fsnotify_kill_group(group);
> +
> + return;
> + }
> + mutex_unlock(&fsnotify_grp_mutex);
> +
> + return;
> +}

do you really need that mutex in the ! case?



\
 
 \ /
  Last update: 2008-11-27 17:19    [from the cache]
©2003-2011 Jasper Spaans