lkml.org 
[lkml]   [2008]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tracing/function-branch-tracer: enhancements for the trace output

* Frédéric Weisbecker <fweisbec@gmail.com> wrote:

> 2008/11/27 Ingo Molnar <mingo@elte.hu>:
> >
> > * Frédéric Weisbecker <fweisbec@gmail.com> wrote:
> >
> >> >> > 0) 0.993 us | }
> >> >> > +0) 11.649 us | }
> >> >> > 0) | do_sync_read() {
> >> >> > 0) | sock_aio_read() {
> >> >> > 0) | __sock_recvmsg() {
> >> >> > 0) | security_socket_recvmsg() {
> >> >> > !0) 100.319 us | cap_socket_recvmsg();
> >> >> > ---------------------------------------------------------
> >>
> >> I like it before the CPU number. The main purpose would be to scroll
> >> quickly the file and find the overheads. That would be easy if set
> >> as a first character.
> >>
> >> I will set it as a default disabled option.
> >
> > lets keep it default-enabled, ok? It makes sense.
>
> Ok.
> BTW I understand why it is better to have a "pipe" if there is no time:
>
> 0) | do_sync_read() {
> 0) | sock_aio_read() {
> 0) | __sock_recvmsg() {
> 0) | security_socket_recvmsg() {
>
> But I don't see why it is necessary to have one just after the time:
>
> !0) 100.319 us | cap_socket_recvmsg();
>
> It appears to me as noise....

if you look at it on a console where you look at code, it all looks
like a straight line:


0) | sys_read() {
0) 0.331 us | fget_light();
0) | vfs_read() {
0) | rw_verify_area() {
0) | security_file_permission() {
0) 0.306 us | cap_file_permission();
0) 0.300 us | cap_file_permission();
0) 8.909 us | }
0) 0.993 us | }
0) 11.649 us | }
0) | do_sync_read() {
. -------------------------
0) ==> [ bash-2794 => cat-1234 ]
-------------------------


as if the code to the right was on a sheet of paper.


If i understand you correct, are you suggesting this format:

0) | sys_read() {
0) 0.331 us fget_light();
0) | vfs_read() {
0) | rw_verify_area() {
0) | security_file_permission() {
0) 0.306 us cap_file_permission();
0) 0.300 us cap_file_permission();
0) 8.909 us }
0) 0.993 us }
0) 11.649 us }
0) | do_sync_read() {
. -------------------------
0) ==> [ bash-2794 => cat-1234 ]
-------------------------

i dont think that looks very good.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2008-11-27 16:07    [W:0.046 / U:1.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site