Messages in this thread | | | Date | Thu, 27 Nov 2008 15:53:16 +0100 | From | "Frédéric Weisbecker" <> | Subject | Re: [PATCH] tracing/function-branch-tracer: enhancements for the trace output |
| |
2008/11/27 Peter Zijlstra <peterz@infradead.org>: > Furthermore, it would be really sweet if ftrace_printk() output would be > at the right indentation level wrt the function it was called from. eg. > > CPU[000] - do_sync_read() { > CPU[000] # sock: 0x12345 flag: 1 > CPU[000] - sock_aio_read() { > ... > CPU[000] + 0.123 } > > > Where the # line is the ftrace_printk() output.
I didn't think of ftrace_printk yet. That's a good idea, this way we will see where the ftrace_printk was called, in which function at which depth....
Don't you think that would be better to have it as C comments. We are in a C-style output and ftrace_printk are especially designed for comments in a trace. That would make sense to read:
do_sync_read() { /* sock: 0x12345 flag: 1 */ sock_aio_read() { 0.123 }
| |