lkml.org 
[lkml]   [2008]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: acpi_evaluate_integer broken by design
Hi!

> > > Len, this looks like 2.6.28 material. But given the poor quality of
> > > the changelog it is hard to be sure about this. Why isn't everyone
> > > seeing these warnings? What did Pavel do to provoke these alleged
> > > warnings? Nobody knows...
> >
> > I don't know know why pavel sees this and nobody else --
> > maybe something unusual he's doing with suspend?

No, playing with driver for HP LED.

Now... I guess the test confused me. Because it tests for
irqs_disabled(), I assumed it was okay to call from interrupt context,
but now I'm not sure at all. Can you help? Comment would be nice.

> If we really do need to inspect global state to handle this, it would
> be much better to create a new
>
> bool resume_is_running_so_you_cant_sleep;
>
> and to test that. Something which is clear, highly specific and which
> cannot be accidentally triggered via other means.

Works for me.
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2008-11-27 15:01    [W:0.138 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site