Messages in this thread | | | Date | Thu, 27 Nov 2008 14:58:45 +0100 | From | Pavel Machek <> | Subject | Re: acpi_evaluate_integer broken by design |
| |
Hi!
> > > Len, this looks like 2.6.28 material. But given the poor quality of > > > the changelog it is hard to be sure about this. Why isn't everyone > > > seeing these warnings? What did Pavel do to provoke these alleged > > > warnings? Nobody knows... > > > > I don't know know why pavel sees this and nobody else -- > > maybe something unusual he's doing with suspend?
No, playing with driver for HP LED.
Now... I guess the test confused me. Because it tests for irqs_disabled(), I assumed it was okay to call from interrupt context, but now I'm not sure at all. Can you help? Comment would be nice.
> If we really do need to inspect global state to handle this, it would > be much better to create a new > > bool resume_is_running_so_you_cant_sleep; > > and to test that. Something which is clear, highly specific and which > cannot be accidentally triggered via other means.
Works for me. Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |