lkml.org 
[lkml]   [2008]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 20/24] perfmon: system calls interface
Hi,

Given that this thread discusses the syscall API, I would like to verify
something with you at this point.

The sys_pfm_create() syscall is used to create a perfmon session (context).
In the current patchset, where only counting is supported, the syscall is
defined as:

int pfm_create(int flags, pfarg_sinfo_t *sif);

The plan is to extend this syscall, instead of adding a new syscall,
to add support
for sampling. The syscall would be used to select which sampling
buffer format and for passing
potential arguments to that format. The syscall would then look like:

int pfm_create(int flags, pfarg_sinfo_t *sif, char *fmt_name, void
*fmt_arg, size_t arg_sz);

The kernel would look at the last 3 arguments ONLY if it saw the
PFM_FL_SMPL_FMT bit
set in flags. We follow the model used by open(2).

I want to double-check that you are fine with this approach.


\
 
 \ /
  Last update: 2008-11-27 13:29    [W:0.092 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site