lkml.org 
[lkml]   [2008]   [Nov]   [27]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateThu, 27 Nov 2008 12:45:25 +0100
FromIngo Molnar <>
SubjectRe: [PATCH] x86: always define DECLARE_PCI_UNMAP* macros
* Joerg Roedel <joerg.roedel@amd.com> wrote:

> Currently these macros evaluate to a no-op except the kernel is 
> compiled with GART or Calgary support. But we also need these macros 
> when we have SWIOTLB, VT-d or AMD IOMMU in the kernel. Since we 
> always compile at least with SWIOTLB we can define these macros 
> always. This patch is also for stable backport for the same reason 
> the SWIOTLB default selection patch is.> > Cc: stable@kernel.org> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
> ---
>  arch/x86/include/asm/pci_64.h |   14 --------------
>  1 files changed, 0 insertions(+), 14 deletions(-)

applied to tip/x86/urgent (for v2.6.28), as this is a DMA mapping 
bugfix for IOMMUs. If the AMD IOMMU is turned on in the .config but 
CONFIG_GART_IOMMU is off (a rare but possible combo), we'd leak on 
unmap and crash the box quickly.

Jesse, is that path of upstream merge fine with you?

	Ingo


\
 
 \ /
  Last update: 2008-11-27 12:49    [from the cache]
©2003-2008