Messages in this thread | | | Date | Wed, 26 Nov 2008 00:35:53 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 2/5] ftrace: use code patching for ftrace graph tracer |
| |
On Wed, 26 Nov 2008 00:27:04 -0800 Harvey Harrison <harvey.harrison@gmail.com> wrote:
> if (code[0] != 0xe9 || old_offset != load32_noalign(&code[1])) > > This is similar to the new API in -mm load_le32_noalign, but I > don't think it would be worth load_u32_noalign...load32 should > be enough. > > > > > > + return -EINVAL; > > > > > + > > > > > + *(int *)(&code[1]) = new_offset; > > > > > > > > Might be able to use put_unaligned_foo() here. > > > > > > > > > > put_unaligned(new_offset, (int *)(&code[1])); > > > > > In a similar vein to above, this becomes: > > store32_noalign(&code[1], new_offset); >
yes, that's much better than the party tricks with magical sizeof, which forces you to run around and check the types of everything.
I've seen people doing get_user() on `long' types and such things occasionally.
| |