lkml.org 
[lkml]   [2008]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] memcg reclaim shouldn't change zone->recent_rotated statics.
On Thu, Nov 27, 2008 at 12:49:46PM +0900, KAMEZAWA Hiroyuki wrote:
> On Tue, 25 Nov 2008 15:54:22 -0800
> Andrew Morton <akpm@linux-foundation.org> wrote:
>
> > On Tue, 25 Nov 2008 12:22:53 +0900 (JST)
> > KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> >
> > > + if (scan_global_lru(sc))
> >
> > mutter. scan_global_lru() is a terrible function name. Anyone reading
> > that code would expect that this function, umm, scans the global LRU.
> >
> > gcc has a nice convention wherein such functions have a name ending in
> > "_p" (for "predicate"). Don't do this :)
> >
>
> Hmm, I'll prepare renaming patch.
>
> scan_global_lru_p() ?

That only works well when you don't have to use underscores, "listp"
or in Lisps where words can be hyphenated "loaded-module-p".

But scan_global_lru_p() looks terrible.

> or under_scanning_global_lru() ?

How about just scanning_global_lru()?

Hannes


\
 
 \ /
  Last update: 2008-11-27 05:03    [W:0.269 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site