lkml.org 
[lkml]   [2008]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRe: [PATCH-mm 8/8] decnet: remove private wrappers of endian helpers
    From
    Date
    On Wed, 2008-11-26 at 21:33 +0000, steve@chygwyn.com wrote:
    > Hi,
    >
    > On Wed, Nov 26, 2008 at 01:12:54PM -0800, Harvey Harrison wrote:
    > > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
    > > ---
    > [snip]
    > > diff --git a/include/net/dn_fib.h b/include/net/dn_fib.h
    > > index 3012511..c378be7 100644
    > > --- a/include/net/dn_fib.h
    > > +++ b/include/net/dn_fib.h
    > > @@ -181,9 +181,9 @@ static inline void dn_fib_res_put(struct dn_fib_res *res)
    > >
    > > static inline __le16 dnet_make_mask(int n)
    > > {
    > > - if (n)
    > > - return dn_htons(~((1<<(16-n))-1));
    > > - return 0;
    > > + if (n)
    > > + return cpu_to_le16(~((1 << (16 - n)) - 1));
    > > + return cpu_to_le16(0);
    > > }
    > You don't need to convert 0.

    Tell that to sparse ;-)

    >
    > [snip]
    > >
    > > @@ -327,7 +327,7 @@ int dn_username2sockaddr(unsigned char *data, int len, struct sockaddr_dn *sdn,
    > > int namel = 12;
    > >
    > > sdn->sdn_objnum = 0;
    > > - sdn->sdn_objnamel = dn_htons(0);
    > > + sdn->sdn_objnamel = cpu_to_le16(0);
    > Again, no need to convert 0 even though I did :-)

    Again, sparse appreciates it.

    >
    > Otherwise the patch looks good.
    >
    > Reviewed-by: Steven Whitehouse <swhiteho@redhat.com>
    >

    Thanks.

    Harvey


    \
     
     \ /
      Last update: 2008-11-26 22:51    [W:0.033 / U:0.396 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site