Messages in this thread |  | | | Date | Wed, 26 Nov 2008 23:10:54 +0300 | | From | Cyrill Gorcunov <> | | Subject | Re: [PATCH 2/5] x86: ret_from_fork - get rid of jump back |
| |
[Andi Kleen - Wed, Nov 26, 2008 at 09:04:33PM +0100] | gorcunov@gmail.com writes: | > --- a/arch/x86/kernel/entry_64.S | > +++ b/arch/x86/kernel/entry_64.S | > @@ -379,7 +379,10 @@ ENTRY(ret_from_fork) | > GET_THREAD_INFO(%rcx) | > testl $(_TIF_SYSCALL_TRACE|_TIF_SYSCALL_AUDIT),TI_flags(%rcx) | > CFI_REMEMBER_STATE | > - jnz rff_trace | > + jz rff_action | > + movq %rsp,%rdi | > + call syscall_trace_leave | > + GET_THREAD_INFO(%rcx) | | The uncommon path is supposed to be out of line. I don't think | the CPU will like that. | | -Andi | | > rff_action: | | -- | ak@linux.intel.com |
Aha! Thanks Andi for review.
- Cyrill -
|  |