Messages in this thread | | | Date | Wed, 26 Nov 2008 15:55:51 +0000 | From | Alan Cox <> | Subject | Re: [PATCH] 8250: fix boot hang with serial console when using with Serial Over Lan port |
| |
> + /* Serial over Lan (SoL) hack: > + Intel 8257x Gigabit ethernet chips have a > + 16550 emulation, to be used for Serial Over Lan. > + Those chips take a longer time than a normal > + serial device to signalize that a transmission > + data was queued. Due to that, the above test generally > + fails. One solution would be to delay the reading of > + iir. However, this is not reliable, since the timeout > + is variable. So, let's just don't test if we receive > + TX irq. This way, we'll never enable UART_BUG_TXEN. > + */ > + if (up->port.flags & UPF_SOL_UART) > + goto dont_test_tx_irq; > +
In the interest of trying to keep the driver sane can that become "UPF_NO_TXEN_TEST" or similar so the same quirk can be applied to other devices with the problem (ditto the pci_intel_sol_setup name could be generalised and the message could give a pci id and "skipping TxEn test" as a debug level note)
Otherwise looks fine to me
(please cc me on serial patches: I think you meant to cc me and Andrew as you cc'd the mysterious "Alan Morton").
| |