Messages in this thread | | | Date | Wed, 26 Nov 2008 14:50:39 +0000 | From | Matthew Garrett <> | Subject | Re: [PATCH] ricoh_mmc: Handle newer models of Ricoh controllers |
| |
On Wed, Nov 26, 2008 at 06:42:20AM -0800, Philip Langdale wrote: > Frans Pop wrote: > >>The latest generation of laptops are shipping with a newer > >>model of Ricoh chip where the firewire controller is the > >>primary PCI function but a cardbus controller is also present. > > > >Note that the current separate ricoh_mmc disabling module approach has > >been shown to break during suspend/resume. Matthew Garret proposed a > >patch for that which (with minor fixups) I tested successfully. > > Hmm. Well, I'm interested as to what Pierre thinks. He explicitly didn't > want a quirk when we originally looked at the problem and that's why > ricoh_mmc exists - but maybe this is a good enough reason to revisit that > decision.
Thinking about it, it could possibly be handled by changing to suspend_noirq and resume_noirq rather than the normal suspend and resume functions? That ought to get the ordering constraints right. The problem occurs when ricoh_mmc suspends before sdhci and resumes after it.
-- Matthew Garrett | mjg59@srcf.ucam.org
| |