lkml.org 
[lkml]   [2008]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 05/24] perfmon: X86 generic code (x86)
On Wed, 26 Nov 2008, Stephen Rothwell wrote:
> Hi Andi,
>
> On Wed, 26 Nov 2008 12:33:09 +0100 Andi Kleen <andi@firstfloor.org> wrote:
> >
> > > + * x86 does not need extra alignment requirements for the sampling buffer
> > > + */
> > > +#define PFM_ARCH_SMPL_ALIGN_SIZE 0
> > > +
> > > +asmlinkage void pmu_interrupt(void);
> > > +
> > > +static inline void pfm_arch_bv_copy(u64 *a, u64 *b, int nbits)
> >
> > All these bitmap wrappers just seem like unnecessary obfuscation.
> > Could you just drop them and call the standard functions directly?
>
> These were added after comments from the PowerPC maintainer since how the
> bitmaps are accessed needs to be arch specific.

Just because perfmon uses u64 for bitfields instead of unsigned
long, therefor it breaks on BE32 machines.

I have not yet found a good reason why it needs to use u64 instead of
using what's there already.

Thanks,

tglx


\
 
 \ /
  Last update: 2008-11-26 14:35    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site