lkml.org 
[lkml]   [2008]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [2.6.28-rc6] oprofile: "opcontrol --start" output two warnings
From
Date
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> writes:
>
> Index: b/arch/x86/oprofile/op_model_p4.c
> ===================================================================
> --- a/arch/x86/oprofile/op_model_p4.c 2008-11-24 06:20:04.000000000 +0900
> +++ b/arch/x86/oprofile/op_model_p4.c 2008-11-24 06:29:09.000000000 +0900
> @@ -399,6 +399,8 @@ static void p4_fill_in_addresses(struct
> unsigned int i;
> unsigned int addr, cccraddr, stag;
>
> + get_cpu();

The whole thing seems broken anyways because the only caller of
fill_in_addresses only assigns to CPU 0 and fill_in_addresses only
runs on some CPU. So I guess the stagger handling could be just
removed because it's useless.

-Andi

--
ak@linux.intel.com


\
 
 \ /
  Last update: 2008-11-25 11:11    [W:0.034 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site